dave-theunsub / clamtk

An easy to use, light-weight, on-demand virus scanner for Linux systems
https://gitlab.com/dave_m/clamtk/wikis/home
Other
349 stars 44 forks source link

Broken AppData file #130

Closed AsciiWolf closed 2 years ago

AsciiWolf commented 3 years ago

The today's release broke the AppData file that I previously fixed in my PR:

  1. You changed the app id to com.github.davetheunsub.clamtk, but you did not change the actual appdata file name to com.github.davetheunsub.clamtk.appdata.xml and you forgot to add the <launchable type="desktop-id">clamtk.desktop</launchable> that is required since you changed the id to one that is not matching the desktop file name.

  2. You removed the <icon type="local" tag, but you did not change the actual icon location to a proper /usr/share/icons/hicolor/128x128/apps/ one. The /usr/share/pixmaps/ path is a legacy icon path that is not supported by AppStream and was workarounded by using the <icon> tag.

So, to fix this mess, I propose to:

  1. Change the appdata file name to com.github.davetheunsub.clamtk.appdata.xml.
  2. Add <launchable type="desktop-id">clamtk.desktop</launchable> to the appdata file.
  3. Change ClamTk icon installation path for clamtk.png to /usr/share/icons/hicolor/128x128/apps/ or at least install a copy of clamtk.png here.

@dave-theunsub Feel free to let me know if you need any help. Thanks!