search

dave-theunsub / clamtk

An easy to use, light-weight, on-demand virus scanner for Linux systems
https://gitlab.com/dave_m/clamtk/wikis/home
Other
357 stars 46 forks source link

Fix appdata file #131

Closed AsciiWolf closed 3 years ago

AsciiWolf commented 3 years ago

Fixes #130.

This fixes the appdata file. The icon can be fixed later by changing this path + changing icon install path and images dir in the Fedora spec file.

/cc @dave-theunsub

dave-theunsub commented 3 years ago

I'm thinking of just changing the spec file and making a copy of the icon for now. Still good?

AsciiWolf commented 3 years ago

Changes from this PR are also needed for the AppStream metadata to be correct. You can add them as a patch for now or make a new tag of ClamTk with the changes included.

AsciiWolf commented 3 years ago

But it's up to you. :-)

dave-theunsub commented 3 years ago

This part - changing icon install path and images dir in the Fedora spec file - is what I'm talking about. Right?

AsciiWolf commented 3 years ago

Yep. :-)

dave-theunsub commented 3 years ago

I should be able to just package the Fedora, CentOS 7, CentOS 8 builds, right? If so, I can just do a minor bump (ie., v6.12-2). No sense in making everyone upgrade if there are no changes to their distro (e.g., Ubuntu).

AsciiWolf commented 3 years ago

These changes can also be used in Ubuntu. But I think that the Debian package does not contain AppData file. So yeah, minor bump should be fine. :-)

dave-theunsub commented 3 years ago

One other thing: by making a copy of the icon and placing in /usr/share/icons/hicolor/128x128/apps/, do I need to change the icon (size)?

Edit: nvm - it's already 128x128.

dave-theunsub commented 3 years ago

Hi @AsciiWolf ,

Do you want to test it first this time?

https://davem.fedorapeople.org/

AsciiWolf commented 3 years ago

Hi Dave,

thanks, the test build looks good. :-)

(Although I am not able to test the actual AppData fix because it needs to be a part of Fedora's AppStream metadata first - this will happen in a next appstream-data package update.)

dave-theunsub commented 3 years ago

Ok, thanks - pushing now.