search

dave-theunsub / clamtk

An easy to use, light-weight, on-demand virus scanner for Linux systems
https://gitlab.com/dave_m/clamtk/wikis/home
Other
349 stars 44 forks source link

Adding time of schedule scan to Status field. #141

Open sebastiancepeda opened 2 years ago

sebastiancepeda commented 2 years ago

Closes #140

Neustradamus commented 6 months ago

@dave-theunsub: What do you think about this PR?

dave-theunsub commented 6 months ago

That looks nice. I recommend changing the "at" - either leaving it out or using "@" or maybe you can think of something else. This way we don't need everyone to update the language files for the change of this one sentence as the change is minor.

dave-theunsub commented 6 months ago

If it's done like this, we won't need new translations:

    if ($scan) {
        $hour_spin_scan->set_value($scan_hour);
        $min_spin_scan->set_value($scan_minute);
        $scan_apply_btn->set_sensitive(FALSE);
        $scan_remove_btn->set_sensitive(TRUE);

        my $statement = _('A daily scan is scheduled');
        my ($status_line_text) =
          sprintf( "%s (%02d:%02d)", $statement, $scan_hour, $scan_minute );
        $scan_status_label->set_text($status_line_text);
    }

Anything between the _( ) portion ends up needing translation. This way we just work around it.