search

dave-theunsub / clamtk

An easy to use, light-weight, on-demand virus scanner for Linux systems
https://gitlab.com/dave_m/clamtk/wikis/home
Other
357 stars 46 forks source link

Change default clamtk user directory from .clamtk to .config/clamtk in App.pm #160

Closed chewblacka closed 9 months ago

chewblacka commented 9 months ago

The XDG Base Directory Specification states that If $XDG_CONFIG_HOME is either not set or empty (as it is on many linux distros), a default equal to $HOME/.config should be used, so ideally the clamtk user directory should default to ~/.config/clamtk (unless ~/.clamtk already exists), not ~/.clamtk

ShamrockLee commented 9 months ago

lib/App.pm line 47 seems to be leftover from #154. Should it be removed here or in another PR?

See https://github.com/dave-theunsub/clamtk/pull/154#pullrequestreview-1789047232

chewblacka commented 9 months ago

lib/App.pm line 47 seems to be leftover from #154. Should it be removed here or in another PR?

See #154 (review)

Thanks I've amended the commit!

ShamrockLee commented 9 months ago

Not sure about the usual workflow in this project, but it is usually preferred to have linear history on the feature branch. Linear history provides a clear set of diffs (changed files) and makes the history after merge simpler. GitHub even provides an option to block PRs with merge commits.

To make the linear history while integrating with new revisions from the base branch, one uses git rebase to bump the feature branch onto the new revision of the base branch, instead of git merge.