dave-tucker / hp-sdn-client

A python library for the HP SDN Controller REST API
Apache License 2.0
9 stars 13 forks source link

Fix requirements parsing in setup.py #11

Closed dave-tucker closed 9 years ago

dave-tucker commented 9 years ago

The method recommended to avoid duplication between requirements.txt and setup.py recommended in StackOverflow [1] no longer works due to a signature change in the parse_requirements method in pip

Instead, we use [2]. requirements.txt defers to setup.py We use "abstract requirements" in setup.py as we're a library.

test-requirements.txt remains intact though it's much cleaner to use:

pip install -r test-requirements.txt
tox -e py27

vs. python setup.py test as there is no control over the options passed to tox

As such, tests_require is probably candidate for deletion.

[1] http://stackoverflow.com/questions/14399534/how-can-i-reference-requirements-txt-for-the-install-requires-kwarg-in-setuptool [2] https://caremad.io/2013/07/setup-vs-requirement/ Signed-off-by: Dave Tucker dave@dtucker.co.uk

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 75.23% when pulling 86ef6760191534afc33437743c8efb7a9d774ac3 on setup.py into f2ae584712c8d0dcbed7b4e07f3a9684acbdadc4 on master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 75.23% when pulling b08682de1cf205fdcca7ee596af3b80b48dfb0ab on setup.py into f2ae584712c8d0dcbed7b4e07f3a9684acbdadc4 on master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 75.23% when pulling b08682de1cf205fdcca7ee596af3b80b48dfb0ab on setup.py into f2ae584712c8d0dcbed7b4e07f3a9684acbdadc4 on master.