search

dave92082 / SolarEdge-Exporter

Prometheus exporter for SolarEdge inverters
MIT License
59 stars 25 forks source link

Add meter reading #3

Closed tansangxtt closed 5 years ago

tansangxtt commented 5 years ago
dave92082 commented 5 years ago

Thanks for the PR, I’ll evaluate and test this week and if all looks good will merge.

Sent from my iPad

On Sep 11, 2019, at 11:53 PM, tansangxtt notifications@github.com wrote:

First meter reading Export 1st meter data to Prometheus You can view, comment on, or merge this pull request online at:

https://github.com/dave92082/SolarEdge-Exporter/pull/3

Commit Summary

Add meter Add metric for meter Update gitignore File Changes

M .gitignore (6) A .idea/runConfigurations/linux_amd64.xml (17) A .idea/runConfigurations/windows_amd64.xml (16) M exporter/metrics.go (238) M main.go (71) M solaredge/Common.go (56) M solaredge/Inverter.go (119) Patch Links:

https://github.com/dave92082/SolarEdge-Exporter/pull/3.patch https://github.com/dave92082/SolarEdge-Exporter/pull/3.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

dave92082 commented 5 years ago

@tansangxtt , asside from duplicating the structs for different names, is there anything else that this change does? If you don't mind me asking, what was you logic behind the rename? I'd rather not have duplicate code.

tansangxtt commented 5 years ago

Hi @dave92082, I added reading meter output. You might not merge this pull request, just for reference