search

daveaglick / FluentBootstrap

Provides extensions, helper classes, model binding, and other goodies to help you use the Bootstrap CSS framework from .NET code.
http://www.fluentbootstrap.com
MIT License
200 stars 76 forks source link

Add support for .SetIcon() for more components #21

Open daveaglick opened 9 years ago

daveaglick commented 9 years ago

Ideally just need to implement IHasIconExtensions but need to be careful that adding the icon as a child works in each case.

daveaglick commented 9 years ago

Another reminder to be careful about adding the icon as a child component - see #28. If the component with IHasIconExtensions generates a wrapping component that should actually contain the icon then the icon will be added to the nested component and not the wrapping component. It should be the responsibility of the IHasIconExtensions implementer to make sure this works out - see the fix for ButtonDropdown.