daveaglick / FluentBootstrap

Provides extensions, helper classes, model binding, and other goodies to help you use the Bootstrap CSS framework from .NET code.
http://www.fluentbootstrap.com
MIT License
200 stars 76 forks source link

div or ul? #27

Closed TheSharedCockpit closed 9 years ago

TheSharedCockpit commented 9 years ago

Why do we get ("FluentBootstrap lets you output this"):

<div class="navbar-left navbar-nav nav">
 <li>...</li>
 <li>...</li>
</div>

and not:

<ul class="navbar-left navbar-nav nav">
 <li>...</li>
 <li>...</li>
</ul>
daveaglick commented 9 years ago

Good question - that certainly seems like a bug.

I can see where it's happening and all my unit tests also have the div instead of the ul. Not sure how that slipped by. Let me just take a look back through the commits to see if there's some reason why I would have done it intentionally (I can't imagine why). Even if I did mean to do it, it's not valid HTML5 markup so it needs to get fixed.

I'll have a patch out hopefully later today.

daveaglick commented 9 years ago

This is now resolved in the develop branch. I'll merge it with master and push a new NuGet package in a bit. Thanks again for reporting this.