search

daveaglick / discoverdotnet

A web site that helps you discover awesome .NET open source and community resources
https://discoverdot.net
MIT License
303 stars 254 forks source link

Handle relative blog links #351

Open RemiBou opened 4 years ago

RemiBou commented 4 years ago

This link to my blog post causes a 404 : https://discoverdot.net/Test-your-JSInterop-code-with-cypress/.

Here is my post link https://remibou.github.io/Test-your-JSInterop-code-with-cypress/ .

RemiBou commented 4 years ago

It looks like the links on my feed are not absolute, I don't know if this is correct or not. This explain also why my feed is failing on dev.to

RemiBou commented 4 years ago

I fixed it by removing feed.xml from my repo, it seems that if there is this file, Type On Strap overrides jekyll-feed. Now it's solved on the feed, I hope the link will be better. But maybe you should detect relative url in the RSS feed and make it absolute. I can work on a PR if you want.

daveaglick commented 4 years ago

But maybe you should detect relative url in the RSS feed and make it absolute.

Totally agree. I'm going to reopen this issue to track that broader problem.