search

daveaglick / discoverdotnet

A web site that helps you discover awesome .NET open source and community resources
https://discoverdot.net
MIT License
303 stars 254 forks source link

Update CommandQuery #458

Closed hlaueriksson closed 3 years ago

hlaueriksson commented 3 years ago

New NuGet: CommandQuery.GoogleCloudFunctions New Tag: GCP (Google Cloud Platform)

hlaueriksson commented 3 years ago

Ouch, I see that the build fails with:

Error: [D:/a/discoverdotnet/discoverdotnet/data/projects/commandquery.yml => data/projects/commandquery.json] Document contains non-approved tag(s): GCP (ValidateProjectTags)

Is GCP a tag that should be added?

daveaglick commented 3 years ago

There's an Azure tag, so I guess it makes sense to add a GCP one as well (and probably an AWS one). Would you mind adding both of those in https://github.com/daveaglick/discoverdotnet/blob/master/Analyzers/ValidateProjectTags.cs as part of this PR? Thanks!

Edit: I take it back, there is an AWS tag, we just don't have any projects under it yet - so just need to add GCP.

hlaueriksson commented 3 years ago

I added GCP in ValidateProjectTags.cs.

The build failed at the actions/setup-dotnet@v1 step, so I thought I might just as well clean up the usings to trigger another build.

daveaglick commented 3 years ago

Great work, thanks! Sorry it's taken such a long time to merge this in.