search

davebalmer / jo

Jo (0.5.0) is a thin (~16K) candy shell for making HTML5 apps. Jo works with: PhoneGap, Chrome, Safari, Opera, FireFox, iOS, Android, BlackBerry 10, Tizen, & Windows Phone 8+. Features include skinnable UI widgets, a clean event model and a light data layer.
MIT License
1.2k stars 180 forks source link

joButton disable doesn't work #23

Closed rretsiem closed 13 years ago

rretsiem commented 13 years ago

Im trying to disable a already instantiated joButton:

// function...
this.addButton = new joButton("Add").selectEvent.subscribe(this.pushDetail, this),
// later
this.addButton.disable();

The button looks like a disabled one, but I can click it and the function gets called...

davebalmer commented 13 years ago

Yeah that looks like a bug to me. :) Will get it fixed.

JohnvdL commented 13 years ago

I just noticed a very able disabled joButton in my app.

Is this broken again?

davebalmer commented 13 years ago

Weird, I'll check. If it's broken I'll get a fix up today or tomorrow. :)

tiqtech commented 13 years ago

Ya, joControl.select doesn't check for this.enabled before it fires selectEvent. Added it in my fork and issued a pull request.

JohnvdL commented 13 years ago

Great, thx!

On Tue, May 17, 2011 at 10:19 PM, tiqtech < reply@reply.github.com>wrote:

Ya, joControl.select doesn't check for this.enabled before it fires selectEvent. Added it in my fork and issued a pull request.

Reply to this email directly or view it on GitHub: https://github.com/davebalmer/jo/issues/23#comment_1192807

The trouble with doing something right the first time is that nobody appreciates how difficult it was -- Walt West "Do the best you can in the time available to you." -- Paul Raymond

davebalmer commented 13 years ago

Fix looks good, closing.