Jo (0.5.0) is a thin (~16K) candy shell for making HTML5 apps. Jo works with: PhoneGap, Chrome, Safari, Opera, FireFox, iOS, Android, BlackBerry 10, Tizen, & Windows Phone 8+. Features include skinnable UI widgets, a clean event model and a light data layer.
MIT License
1.2k
stars
180
forks
source link
Couple fixes to joSlider and change to joDOM.setStyle #39
Noticed a couple bugs while using joSlider in a prototype.
If you set a starting value and have a min/max range set, the slider doesn't position itself correctly. This appears to be due to not incorporating the min in the math. Added that and things look correct
The mouseup event for dragging the thumb isn't unbound correctly. It's missing the capture flag to joEvent.remove()
Also added slideStart and slideEnd events. Right now, it fires change events as the slider moves but I wanted to react to the changed value only when sliding is done. Seemed like it would be something others would want as well.
Finally, I noticed that unlike joDOM.addCSSClass, joDOM.setStyle only accepts a HTMLDOMElement and not a joView (or derivative). So, added joDOM.get(node) at the top of that to make it congruent with the other methods.
davebalmer
commented
13 years ago
Noticed a couple bugs while using joSlider in a prototype.
Also added slideStart and slideEnd events. Right now, it fires change events as the slider moves but I wanted to react to the changed value only when sliding is done. Seemed like it would be something others would want as well.
Finally, I noticed that unlike joDOM.addCSSClass, joDOM.setStyle only accepts a HTMLDOMElement and not a joView (or derivative). So, added joDOM.get(node) at the top of that to make it congruent with the other methods.