search

davebraze / FDBeye

R tools for eyetracker workflows.
https://davebraze.github.io/FDBeye/
Other
118 stars 14 forks source link

change to system2() to work with both mac and windows #34

Closed monicaycli closed 6 years ago

monicaycli commented 6 years ago

It appears to me that using type = "cmd2" in shQuote() should make it work with both Mac and Windows. When I tested with my Mac, only type = "cmd2" would work, and based on the manual for shQuote(), "cmd2" is the one preferred for cmd.exe on Windows anyway. It might cause problem for Mac when there are double quotes in the file names, though. Perhaps we should check file names and ask the user to remove double quotes from file names?

davebraze commented 6 years ago

Ok. This did not work on windows. I tried changing to type="cmd" in the shQuote() wrapper for the exe string only. That also did not work. I then dropped the shQuote() wrapper around the exe string altogether, but left it in place for the argument string. That did work.

However, I note that the log file does not get written.

closes issue #12.