davechallis / rust-xgboost

Rust bindings for XGBoost.
MIT License
102 stars 37 forks source link

Change missing from 0 to NaN #20

Closed vbkaisetsu closed 7 months ago

vbkaisetsu commented 8 months ago

This branch changes the value of the missing argument from 0 to NaN to match the default behavior of the Python front end. https://github.com/dmlc/xgboost/blob/a197899161fa70e681101de4232745fdfe737804/python-package/xgboost/core.py#L843

montanalow commented 8 months ago

@vbkaisetsu inspired me to update our branch after his contribution. This is included in #21