search

davecheney / httpstat

It's like curl -v, with colours.
MIT License
6.97k stars 382 forks source link

Sort headers before printing #16

Closed mibk closed 7 years ago

davecheney commented 7 years ago

I thought about this previously and have two suggestions.

  1. http headers are not sorted, they probably get unsorted more in this version compared to the python version because of the way maps work in Go vs whatever curl is doing.
  2. if we are going to sort headers, it shouldn't just be plain alpha sort, it should

I know this is more work, but I think this is only worth doing if it's done to this degree of precision.

davecheney commented 7 years ago

Also, please read the contributing section about slinging code before discussing a feature. I would like it if you took my comment https://github.com/davecheney/httpstat/pull/16#issuecomment-249330987 and created a new issue where we can discuss the implementation before jumping to the code.

mibk commented 7 years ago

Apologies, this is my mistake. I have read the contributing section but thought this is a small and reasonable enough change it's not worth creating an issue for it. Well, lesson learnt. Sorry again.

Your suggestion seems reasonable. I think I'm able to do it. But now I should probably go to bed...

davecheney commented 7 years ago

This is my fault, I should have made it clear in the to-do that sorting isn't implemented because I wanted something more than just an alpha sort.

On Sat, 24 Sep 2016, 10:31 Michal Bohuslávek notifications@github.com wrote:

Apologies, this is my mistake. I have read the contributing section but thought this is a small and reasonable enough change it's not worth creating an issue for it. Well, lesson learnt. Sorry again.

Your suggestion seems reasonable. I think I'm able to do it. But now I should probably go to bed...

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/davecheney/httpstat/pull/16#issuecomment-249332280, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAcA9miog-B3zXrlNj3ogkuWgGkNbuEks5qtG9vgaJpZM4KFf7f .