search

davecheney / httpstat

It's like curl -v, with colours.
MIT License
7.05k stars 384 forks source link

HTTPSTAT_SHOW_BODY: default response body to a temp file #20

Closed amy closed 8 years ago

amy commented 8 years ago

PR in progress

davecheney commented 8 years ago

This branch is based off an old revision of master, you'll need to rebase.

amy commented 8 years ago

What is the purpose of this line: https://github.com/davecheney/httpstat/blob/master/main.go#L182

Also, should I separate the temporary-file-logic into another function. @davecheney

davecheney commented 8 years ago

What is the purpose of this line: https://github.com/davecheney/httpstat/blob/master/main.go#L182

It was just a placeholder, if you look at the httpstat.py project, that was where they reported the name of the temporary file the response was written too.

Also, should I separate the temporary-file-logic into another function. @davecheney

Yes, it's a good time to start doing that.

Also check out #35 as @gbbr is also working on a part of this problem.

amy commented 8 years ago

@davecheney Its pretty rough, so would love some comments.

I'm not sure if I referenced the correct flag on line 182 when you talked about the -l flag. Also, the response size seems like it needs to be limited, wasn't sure what size to decide on.

amy commented 8 years ago

@davecheney annnnd again!

davecheney commented 8 years ago

Hopefully #50 will have made this PR easier to integrate.

amy commented 8 years ago

Cool! I'll close this now. Looks like #48 handled this. @davecheney

davecheney commented 8 years ago

Sure thing. There are plenty of other bugs if you want to take a crack at one of those.

On Mon, Sep 26, 2016 at 1:13 PM, Amy Chen notifications@github.com wrote:

Closed #20 https://github.com/davecheney/httpstat/pull/20.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/davecheney/httpstat/pull/20#event-801721722, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAcA1G5Ql1FnYRh2MVERrB8p4E3YUNsks5qtzhygaJpZM4KFg5k .