search

davecheney / httpstat

It's like curl -v, with colours.
MIT License
6.96k stars 382 forks source link

Add 'https://' to URLs submitted with no scheme #37

Closed Xymist closed 7 years ago

Xymist commented 7 years ago

Plus some linting if that's of any value at all.

davecheney commented 7 years ago

@Xymist please take a look at #31 as there is probably some overlap between the two pull requests.

Xymist commented 7 years ago

MHolt's comments were valuable. I dispute the need for an additional function as mvrilo has used, but you're right. There's a significant overlap.

davecheney commented 7 years ago

Fixes #26

davecheney commented 7 years ago

Positive.

On Sun, Sep 25, 2016 at 9:12 PM, James Duerden notifications@github.com wrote:

@Xymist commented on this pull request.

In main.go https://github.com/davecheney/httpstat/pull/37:

@@ -157,7 +180,7 @@ func visit(url *url.URL) { log.Fatalf("unable to create request: %v", err) }

  • if err := req.Write(conn); err != nil {
  • if err = req.Write(conn); err != nil {

err is shadow-declared several times; are you sure?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/davecheney/httpstat/pull/37, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAcA3nLY3Wf-YlF-qLbfzH4mm0gSoVTks5qtlcRgaJpZM4KFvjA .

davecheney commented 7 years ago

I'll fix the conflicts and merge this now.