search

davecheney / httpstat

It's like curl -v, with colours.
MIT License
6.97k stars 382 forks source link

Use fatih/color package for colorizing #4

Closed n10v closed 7 years ago

n10v commented 7 years ago

Do second TODO, because color package detect tty. And IMHO grayscale looks not good and should be changed

davecheney commented 7 years ago

@amy was looking at switching color off/on, so I've asked her to integrate matt-n's isatty package into her change.

I'm fine with using Fatih's color package, but please vendor/ it.

n10v commented 7 years ago

Done!

davecheney commented 7 years ago

Sorry, there are more conflicts. Now #8 has landed, please rebase.

davecheney commented 7 years ago

Your .gitmodules file is missing. I use https://github.com/dpw/vendetta to automate this for me.

n10v commented 7 years ago

Sorry, it's my first time using /vendor package.

davecheney commented 7 years ago

Yeah, it's not that easy to use, sorry.

On Sat, Sep 24, 2016 at 9:04 AM, Albert notifications@github.com wrote:

Sorry, it's my first time using /vendor package.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/davecheney/httpstat/pull/4#issuecomment-249322165, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAcA52NaxG_pF0ziWDX3xolX6sksYj4ks5qtFr4gaJpZM4KFDml .

davecheney commented 7 years ago

When this merges would you please send a PR to update the screenshot. Thanks.

n10v commented 7 years ago

And I can't still understand, why it should be used😅 Specially in this tool

n10v commented 7 years ago

But the appearance and colors didn't changed. I stayed all how it was been.

davecheney commented 7 years ago

The screenshot is actually a little out of date anyway.

If you don't want to update it, that's fine, I'll do it when https support lands.