search

davecheney / httpstat

It's like curl -v, with colours.
MIT License
7.05k stars 384 forks source link

pty state: Coloring based on stdout #8

Closed amy closed 8 years ago

amy commented 8 years ago

Wasn't sure about your thoughts on pulling in another dependency to determine stdout state. Reference: https://rosettacode.org/wiki/Check_output_device_is_a_terminal#Go

davecheney commented 8 years ago

Thanks @amy. I'm fine with external dependencies, but they should be vendor/ ed. Do you want to take a look at #4 and

  1. vendor the package that is used there, it does the same thing but isn't mixed up with the ssh package (which is a long standing issue of the ssh/terminal package).
  2. Switch to that package?
amy commented 8 years ago

Cool. I'll make the switch!

davecheney commented 8 years ago

Hold tight, I'm just getting a travis build set up. Please rebase when #11 has landed.

davecheney commented 8 years ago

11 has landed, please rebase or merge master and try again. Thanks!

davecheney commented 8 years ago

Thanks!