Closed n10v closed 6 years ago
To all the watchers on this project. Please read my comment, https://github.com/davecheney/httpstat/issues/5#issuecomment-249399745, and provide feedback on this proposal.
Thank you.
@bogem please include an updated screenshot.png in this PR.
@davecheney would you like with white or black background?
Ok, I will use a black one
I need others to review this proposal. Please read my comment, #5 (comment), and provide feedback on this proposal.
Thank you.
a little glare for "solarized dark theme"
I'm a little ambivalent. The original style is fine with me, but @bogem's works for me, too. I hate white terminals, so I'm struggling to care.
I like it. I became used to light terminals, and it looks really good on it.
This is no good on my terminal. The blue is too dark:
The version in master
is exponentially more appealing to me WRT color:
👎 from me.
Obviously it's very subjective theme. Maybe it will be better to use no colors:
@bogem thank you for your contributions. It's clear to me that we're not going to get a strong positive opinion to change the colour scheme, which means the current colour scheme is no better or no worse than any other.
However there is strong support for removing colour, and just going with bold. Again, I cannot make this decision because while I personally dislike all screen colouring because of my colour blindness, I recognise my taste is unusual.
I'm going to cut a 1.0.0-rc.1 release now and hopefully a little more time will give a clearer answer on changing the colour scheme.
I program without syntax highlighting, so I can easily live without colors.
If we drop escape codes completely, we drop 3 of 4 external package dependencies. Once the stdlib completely enables the http2 implementation, we could end up with zero external dependencies. :tada:
Otherwise, I vote for bold instead of colors.
I used color
package for bold, but I can make own color function or just copy code from color
and go-isatty
packages with copyrights.
And what are you thinking of version with no colors at all? I think, it looks pretty and clear.
Here is what I propose. I'm just about to cut 1.0.0 and say this will be the final release. I'm happy to do a 1.1 with some controllable colour pallet. How does that sound?
How would colors be controlled? With environment variables? I think, this feature is redundant and overhead. We should just decide for a color scheme. I vote for bold
@bogem I'm going to assume that the majority of httpstat
users are happy with the current color scheme. I'm in that group, so I vote that the color scheme should stay as-is with no modifications. If we want to support a mode without colors (where bold is substituted), or different color schemes altogether, I think it should be an opt-in change and not the default for all users. The current vibrant output is one of the reasons I like using this utility. 😄
I've a fork that I've made some enhancements to (mostly around CLi flags) and I was thinking about how to solve this problem there. The first challenge is to just get the code printing the right stuff based on the perceived color "toggle". The second is the UX around those toggles. I think there are few ways to solve it the toggle problem, and all could be easily implemented:
HTTPSTAT_NO_COLOR
maybe?)-N
for no-color
mode, but that means you'll need to remember to use it on each invocation which is annoying (although a shell alias
may solve it).httpstat
could look at on start. (~/.httpstat-nc
maybe?)What do you think?
@theckman no-color flag is better idea. I think, it should be implemented so
I'm sorry for not closing this a long time ago. As I explained, I'm not changing the color scheme. Sorry, that's the decision.
Fixes #5
Changes:
IMHO it's a lot more readable now on white backgrounded ttys and also readable on black:
![screenshot](https://cloud.githubusercontent.com/assets/13235519/18916232/12e1cefe-8594-11e6-9fd5-f16307cbdd9c.png)