davechurchill / StarcraftAITournamentManager

Tournament Manager Software for StarCraft AI Competitions
MIT License
77 stars 43 forks source link

File I/O not synchronized immediately between rounds #28

Closed krasi0 closed 5 years ago

krasi0 commented 6 years ago

I'm using the tournament manager in a way where the game schedule has every following game to also be in a new round, e.g. ... game 15, round 0 game 16, round 1 game 17, round 2 ... Hoping that the TM would synchronize the File I/O after each round. It looks like that doesn't always work though. For example, I tested with the following games: BotA vs BotB, BotB vs BotA, BotA vs BotB and in the third game, BotA didn't seem to have access to the second game. What could the issue be? Is File I/O really synchronized after each round or could there be any delays?

richard-kelly commented 6 years ago

It should be synchronized after every round if EnableBotFileIO is set to true in the server settings.

krasi0 commented 6 years ago

Yes, it is enabled. Weird... Keep in mind that in this case, each game is a separate round.

On Thu, Mar 22, 2018 at 3:51 PM, Rick Kelly notifications@github.com wrote:

It should be synchronized after every round if EnableBotFileIO is set to true in the server settings.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davechurchill/StarcraftAITournamentManager/issues/28#issuecomment-375312977, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5gO81v28UHBov0H3E6ZyquSt0CDx8Wks5tg6xZgaJpZM4S26hI .

-- BR

richard-kelly commented 6 years ago

The server should print to the GUI log: "Moving Write Directory to Read Directory" every time it's about to do that. How often does that happen?

krasi0 commented 6 years ago

I can see it printed before every new game

On Thu, Mar 22, 2018, 16:28 Rick Kelly notifications@github.com wrote:

The server should print to the GUI log: "Moving Write Directory to Read Directory" every time it's about to do that. How often does that happen?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davechurchill/StarcraftAITournamentManager/issues/28#issuecomment-375325833, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5gO9WeRHZW2WeDa2JpeAb3lMoPquo-ks5tg7UGgaJpZM4S26hI .

richard-kelly commented 6 years ago

I just did a quick test with a two bot tournament and I'm seeing the correct behaviour (1vsall and allvsall). It shouldn't matter if you have a custom games list either. Any errors printed to the server console (not the GUI log)?

krasi0 commented 6 years ago

Nope, no errors. I mean files do get transferred from read/ to write/ as expected. It's just that when you have multiple games with the same 2 players changing slots (A vs B, B vs A, A vs B) it is as if some of the games in between (in this particular case B vs A) get lost in terms of data stored into write/. Weird indeed...

On Thu, Mar 22, 2018 at 6:45 PM, Rick Kelly notifications@github.com wrote:

I just did a quick test with a two bot tournament and I'm seeing the correct behaviour (1vsall and allvsall). It shouldn't matter if you have a custom games list either. Any errors printed to the server console (not the GUI log)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davechurchill/StarcraftAITournamentManager/issues/28#issuecomment-375375463, or mute the thread https://github.com/notifications/unsubscribe-auth/AF5gO0-k3Itx_QQV8sEktbX1uTnOWQ5Vks5tg9UQgaJpZM4S26hI .

-- BR