search

davecoffin / nativescript-filterable-listpicker

Apache License 2.0
44 stars 22 forks source link

Update filterable-listpicker.ts #2

Closed shiv19 closed 6 years ago

shiv19 commented 6 years ago

Proposing a change to avoid the setTimeout approach

davecoffin commented 6 years ago

This wont work, you are setting the unfiltered array to the source every time the user types, and then filtering source below it, therefore making the unfiltered source filtered, so as you delete letters you wont unfilter the listview.

davecoffin commented 6 years ago

I take it back, I see what youre doing here. But I think I found a better way to do it, and just updated.

shiv19 commented 6 years ago

Love the new solution, it is much better 😄