davecoffin / nativescript-filterable-listpicker

Apache License 2.0
44 stars 22 forks source link

selectedItem from unfiltered list returns "undefined" #24

Closed virtualbjorn closed 6 years ago

virtualbjorn commented 6 years ago

Make sure to check the demo app(s) for sample usage

Make sure to check the existing issues in this repository

If the demo apps cannot help and there is no issue for your problem, tell us about it

Please, ensure your title is less than 63 characters long and starts with a capital letter.

Which platform(s) does your issue occur on?

Please, provide the following version numbers that your issue occurs with:

Please, tell us how to recreate the issue in as much detail as possible.

Describe the steps to reproduce it.

Is there any code involved?

virtualbjorn commented 6 years ago

I know how to fix it. I'm gonna do a pull request to the repo.

virtualbjorn commented 6 years ago

@davecoffin I can't push my contribution to your repo since I'm not one a collaborator yet.

davecoffin commented 6 years ago

Create a fork of the repo and submit a pull request so I can review.

Why are your core modules still on 3.x? "tns-core-modules": "~3.1.0", That could be your problem if your runtimes and cli version are on 4.x, you need to update your core modules.

virtualbjorn commented 6 years ago

I tried it on newer template still the same error, but I found a work around though. Just need to try it out.

davecoffin commented 6 years ago

Have you tried the demo app?

virtualbjorn commented 6 years ago

I tried running the demo app but to no avail. So I created a new angular template then added the plugin. Successfully implemented the demo but in first instance of the listpicker when you haven't filtered it yet and selected an item, for example you directly tapped the unfiltered list item and it returns undefined on alert.

davecoffin commented 6 years ago

I'm closing this because I can't reproduce it. Try the latest version, 2.1.0.