search

davecoffin / nativescript-modal-datetimepicker

Apache License 2.0
59 stars 36 forks source link

Fix NativeClass not found exception #78

Closed Logikgate closed 3 years ago

Logikgate commented 3 years ago

This commit makes sure that ts-patch is run when npm run build is ran. This will make it impossible for the plugin to be published without having ts-patch ran which has caused #77

Once merged, doing a npm run clean & npm run build prior to publishing will fix #77

Logikgate commented 3 years ago

@davecoffin Could you please review and publish a new version to npm? The current version appears to be broken for all users since it didn't have ts-patch ran prior to publishing :smile:

jelledijkstra97 commented 3 years ago

@davecoffin I would also appreciate if you merge this commit. The plugin is unusable at the moment...

davecoffin commented 3 years ago

Sorry for the delay guys! Covid. Holidays. Fuck. Merged and published 2.1.4

davecoffin commented 3 years ago

sorry, 2.1.5

PatrickLohan commented 3 years ago

It's ok, we can understand how all 3 given reasons would be distracting :rofl:

jelledijkstra97 commented 3 years ago

Thnx!

Logikgate commented 3 years ago

Thank you!

jeroendk commented 3 years ago

Awesome!