search

davedelong / DDMathParser

String → Number
MIT License
854 stars 153 forks source link

Swift 3: Deprecated constants M_PI, DBL_MAX, DBL_MIN trigger warnings on build #137

Closed edovey closed 7 years ago

edovey commented 7 years ago

Examples:

.../Pods/DDMathParser/MathParser/Functions+Defaults.swift:188:63: 'DBL_MIN' is deprecated: Please use 'Double.leastNormalMagnitude' or '.leastNormalMagnitude'.

.../Pods/DDMathParser/MathParser/Functions+Defaults.swift:696:23: 'M_PI' is deprecated: Please use 'Double.pi' or '.pi' to get the value of correct type and avoid casting.

Build target is iOS 9.1, using Swift (3), Xcode 8.3.2.

nezhyborets commented 7 years ago

Same issue here. @edovey what version of DDMathParser do you have? My cocoapods downloads 2.0.0 for some reason, but it seems that the most recent version is 3.0.0

edovey commented 7 years ago

@nezhyborets , Version 3.0.0 (Swift). My podfile has this entry for DDMathParser:

pod 'DDMathParser', :git => 'https://github.com/davedelong/DDMathParser.git', :tag => '3.0.0'
edovey commented 7 years ago

Issue still occurs with last patch to Xcode 8.3.3.

davedelong commented 7 years ago

This should be fixed on the master and swift4 branches.

edovey commented 7 years ago

Thank you!

On Jul 29, 2017, at 3:24 PM, Dave DeLong notifications@github.com wrote:

This should be fixed on the master and swift4 branches.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/davedelong/DDMathParser/issues/137#issuecomment-318860603, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVEhV9TEi_WiQbWthtnXq9wdE_zbJU4ks5sS6L1gaJpZM4Nc6zU.

nezhyborets commented 7 years ago

Works on master but Cococapods still gives 2.0.0, so switched to Submodules