search

davedelong / DDMathParser

String → Number
MIT License
854 stars 153 forks source link

Upgrade to Swift 4.2 #156

Closed ffried closed 5 years ago

ffried commented 6 years ago

Goal of this PR is to be ready for Swift 4.2 by the time it is released.

I'll try to keep this branch (and with it the PR) updated along the betas. If things stay the way they are now, this will be easy. The only changes currently necessary were to update the project file and scheme settings.

ffried commented 6 years ago

Correction: The test for Issue #113 is crashing because of an overflow. I changed the condition from self <= Double(Int.max) to self < Double(Int.max) to fix this.

ffried commented 6 years ago

@davedelong With Xcode 10 (and Swift 4.2) now being released as GM, this PR is ready. Just ran the tests again against the simulator and the mac and it looks all good.

ffried commented 5 years ago

Pinging @davedelong 🙂