fixed PHP Warning in Illuminate/Database adapter

[michael-mader]

in fetchAll method array_map is called with the result of this statement:

$all = $this->adapter
  ->table($this->tableName)
  ->orderBy('version')
  ->get();

But get() returns an instance of \Illuminate\Support\Collection which is not accepted by array_map. There a call to toArray() has to be added to convert the Collection to an array

[davedevelopment]

Thanks!

[ricardorzgz]

Hi, this is not right, the table() function returns an instance of Query\Builder so the get returns an array not a Collection, so after this commit this package is broken for Laravel. The toArray() function is only available for the Eloquent Builder.

PHP Fatal error: Call to a member function toArray() on a non-object in vendor/davedevelopment/phpmig/src/Phpmig/Adapter/Illuminate/Database.php on line 47

[michael-mader]

hm what version of Illuminate/Database do you use? maybe there was a change?

edit: It is working with version 5.3

[ricardorzgz]

I'm working with 5.2.45, and

$this->adapter
  ->table($this->tableName)
  ->orderBy('version') 

is returning a Illuminate\Database\Query\Builder so cannot use toArray() there.

[michael-mader]

ok, so we have to check what is returned and only call toArray() for \Illuminate\Support\Collection.

Is it working if you remove toArray()? Is the Builder automatically converted to array?

[ricardorzgz]

Yes, if I remove toArray() is working. Query Builder returns an array

[michael-mader]

can you provide a new pull request fixing this issue for both versions? Maybe we should check if get() returns an array, if not call toArray() to convert it. This should work for you and for me

[ricardorzgz]

Done