search

davedevelopment / phpmig

Simple migrations system for php
Other
569 stars 92 forks source link

Patch all occurences of phpmig.sets with deep level key access w/o parent #147

Closed davehewy closed 4 years ago

davehewy commented 4 years ago

Hi,

Simple bug fixes for undefined phpmig.sets keys when accessing deeply nested keys on the pimple container.

Seems to get things working again. Tested against Pimple v3.2.3

davedevelopment commented 4 years ago

Great thank you.

davehewy commented 4 years ago

Going to create a release?

davehewy commented 4 years ago

Just patch v1.6.0 though. Do not push your other staged changes in master :)

davedevelopment commented 4 years ago

Morning! Is there something wrong with the other changes...?

davehewy commented 4 years ago

Bumps to PHP 7+. You can still release the other changes later as v1.7.0 but would be better to also offer a patched working version that requires only 5.3.2+ at say v1.6.1. Otherwise, you alienate all the older installs in one swift move

davedevelopment commented 4 years ago

Do you need PHP <7?

I'm happy to alienate, I can't keep supporting forever and I'd need to create a 1.6 branch, then cherry pick your commit as you branched master etc..

davehewy commented 4 years ago

I do (sorry). Yep branch from your v1.6.0 tag cherry-pick my commit and then re-tag + push. Easy enough

davedevelopment commented 4 years ago

:+1: already done