davedevelopment / phpmig

Simple migrations system for php
Other
569 stars 92 forks source link

Migration::__construct() "final" key word decreases usability #155

Open daimaxiong opened 2 years ago

daimaxiong commented 2 years ago

The constructor's signature is final public function __construct()

I would like to make a base class for my migrations that extends Phpmig\Migration\Migration and does some custom configuration/initilization tasks.

The logical goto for that is the constructor, however, I cannot do that, because the parent class's constructor is marked final.

Please remove this in a future version

davedevelopment commented 2 years ago

I think the engine probably depends on the constructor being the way it is, hence the final. We'd need something more robust than just removing the final on the constructor.