search

davedoesdev / bpmux

Node stream multiplexing with back-pressure on each stream
MIT License
18 stars 2 forks source link

Test using frame-streams on multiplexed streams #2

Closed davedoesdev closed 6 years ago

davedoesdev commented 6 years ago

@OEvgeny mentioned on #1 that it may not be working, so add a test for it.

OEvgeny commented 6 years ago

I was wrong. Got it to work properly. Adding test is always a good idea though!

davedoesdev commented 6 years ago

No problem - I agree adding a test is a good idea. Thanks for letting me know.

davedoesdev commented 6 years ago

Added test in 9b8db84

davedoesdev commented 6 years ago

Btw, @OEvgeny if you're using TCP, I discovered that disabling Nagle (setNoDelay) can boost performance.

OEvgeny commented 6 years ago

That's good to know. Thanks!