daveenguyen / atomacos

Automated Testing on macOS
https://daveenguyen.github.io/atomacos/
GNU General Public License v2.0
48 stars 13 forks source link

feat: Add support for AXFrame(CGRect) value type #15

Closed timurco closed 3 years ago

timurco commented 3 years ago

Added support for AXFrame value type. With x,y, width and height attributes. .. P.S. This is my first pull request. Sorry if something is not correct

daveenguyen commented 3 years ago

Thanks for the contribution!

I haven't touched this in a while and it looks like the build is broken. I'll look into it tomorrow and hopefully get your changes merged in.

In the meantime, can you do me a favor and find/share a native macO example of AXFrame?

And if possible add a test like this https://github.com/daveenguyen/atomacos/blob/d1836345e29d54950e61d40bd24490a715280f77/tests/test_atomacos.py#L87-L91

front_title_ui is from conftest.py if that part is confusing https://github.com/daveenguyen/atomacos/blob/d1836345e29d54950e61d40bd24490a715280f77/tests/conftest.py#L55-L72

Thanks again for your help

timurco commented 3 years ago

It's just like a CGPosition and CGSize, but combined in one CGRect. Native Finder have this by default Here is screenshot of finder

But I use this to automate Screenflow with auto-editing.

A little bit later I will add that tests. And need to create new pull requests with 2 commits (AXFrame+Tests), Right?

daveenguyen commented 3 years ago

You can continue working on your branch and it'll update this pull request. No need to create a new pull request. Just got travis working again in the latest master.

codecov[bot] commented 3 years ago

Codecov Report

Merging #15 (80af571) into master (e2eceab) will decrease coverage by 0.70%. The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   93.09%   92.39%   -0.71%     
==========================================
  Files          14       14              
  Lines         637      644       +7     
==========================================
+ Hits          593      595       +2     
- Misses         44       49       +5     
Impacted Files Coverage Δ
atomacos/_converter.py 86.00% <28.57%> (-9.35%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2eceab...80af571. Read the comment docs.