daveewart / colordiff

Primary development for colordiff
http://www.colordiff.org/
GNU General Public License v2.0
177 stars 37 forks source link

colordiff-1.0.17 doesn't colorize anymore when piped through less #33

Closed heirecka closed 7 years ago

heirecka commented 7 years ago

Since updating to 1.0.17 colordiff doesn't colorize diffs anymore when piped through less. It even worked without passing -R/-r to less in the past, but now that doesn't help either. Nor does explicitly passing --color=yes to colordiff or setting color_patches=yes. Version of less is 492.

daveewart commented 7 years ago

Oh, damn, I was particularly trying to avoid breaking that: it's one of the most common use cases. Will fix this a.s.a.p. Thanks for the report.

daveewart commented 7 years ago

One line fix ;-)

@heirecka - please try 1.0.18 release or latest git and re-test.

heirecka commented 7 years ago

That was quick :-) Thank you!

daveewart commented 7 years ago

I was watching 'The Godfather Part III' and spotted your email: knew it was a very annoying bug that needed dealt with. Now back to those nice Italian American gentlemen ... ;-)