search

daveewart / colordiff

Primary development for colordiff
http://www.colordiff.org/
GNU General Public License v2.0
177 stars 37 forks source link

Support config file on Windows. #54

Closed rkitover closed 2 years ago

rkitover commented 2 years ago

Use the env vars HOME, USERPROFILE for home location, in that order.

Use XDG_CONFIG_HOME, LOCALAPPDATA and APPDATA for user config dir location, in that order.

Signed-off-by: Rafael Kitover rkitover@gmail.com

rkitover commented 2 years ago

Sorry, didn't see that this was a fork.

rkitover commented 2 years ago

And now I didn't check that the original is dead, are you the current de-facto maintainer of this project?

daveewart commented 2 years ago

Hi Rafael. I’m the author and maintainer of colordiff, yes. Spotted this pull request earlier but haven’t had a time to review: looks pretty straightforward, so don’t imagine there will be an issue to merge, for the record.

[FYI History of the ‘kimmel’ repository is this: I wrote colordiff more than 20 years ago, before GitHub existed, and in about 2011 kimmel put a copy of the source up on GitHub but then took the code in a very strange direction. After what one would probably call a disagreement, he stopped working on it. So I forked it back and this is where we are today!]

rkitover commented 2 years ago

Thank you for the explanation, I am going to try to make a Chocolatey package for this software, should be fairly straightforward.

daveewart commented 2 years ago

OK, merged. Good luck with the Chocolatey package :-)

rkitover commented 2 years ago

Awesome, thank you very much!

If I could ask you one more thing, could you please make another tag.

This really helps with the packaging (the updater powershell script looks at releases/tags.)

rkitover commented 2 years ago

Actually hold off for a bit, I need to fix the exit code, I'll send you another PR shortly.

rkitover commented 2 years ago

Never mind, the exit code is correct, I forgot that diff exits non-zero when there is a diff.

daveewart commented 2 years ago

I should probably do a new release and call it 1.0.20 - might take me a few days to get around to doing so because I need to update the housekeeping (Changelog etc.). Do you want a temporary tag just for something to work against or OK to wait?

rkitover commented 2 years ago

It's cool I can wait, thank you very much!

daveewart commented 2 years ago

FYI release tag 1.0.20 now in place.