Jacoby6000 commented 6 years ago

This probably shouldn't be merged until the official cats 1.0 release, but I'm going to let it sit here so it doesn't get forgotten.

The biggest deal here is removing the need for Indexable, and the removal of scalaz as a dependency.

codecov[bot] commented 6 years ago

Codecov Report

Merging #12 into develop will increase coverage by 2.82%. The diff coverage is 93.33%.

@@             Coverage Diff             @@
##           develop      #12      +/-   ##
===========================================
+ Coverage    81.95%   84.77%   +2.82%     
===========================================
  Files           13       11       -2     
  Lines          205      197       -8     
  Branches         2        3       +1     
===========================================
- Hits           168      167       -1     
+ Misses          37       30       -7

Impacted Files	Coverage Δ
...n/scala/checklist/refinement/RuleHListSyntax.scala	`100% <100%> (ø)`	:arrow_up:
checklist/src/main/scala/checklist/Rule.scala	`85.71% <100%> (+4.79%)`	:arrow_up:
checklist/src/main/scala/checklist/Path.scala	`81.81% <100%> (+8.13%)`	:arrow_up:
checklist/src/main/scala/checklist/Message.scala	`83.33% <50%> (-16.67%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ff796f...fc12d34. Read the comment docs.

AlexaDeWit commented 6 years ago

I'd love to see a 1.0 bump here when the cats release is official (Rob says probably before Christmas!).

I am looking at this library but I am using 1.0-RC1 of cats and thus effectively can't. Share the love please 👯

Jacoby6000 commented 6 years ago

Cats 1.0 release is out. Now just need to wait for monocle to finish their milestone releases.

Jacoby6000 commented 6 years ago

Monocle release should be soon. julien-truffaut/Monocle#550

Jacoby6000 commented 6 years ago

After CI passes this should be good for release.

I'm not sure what the release strategy should be for this.

Jacoby6000 commented 6 years ago

@davegurnell How should we go about getting this out in to the wild? Increase minor release or what?

davegurnell commented 6 years ago

Yeah. Minor release, I reckon. I'll start on it now.

On Mon, Jan 29, 2018 at 4:12 PM Jacob Barber notifications@github.com wrote:

@davegurnell https://github.com/davegurnell How should we go about getting this out in to the wild? Increase minor release or what?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/davegurnell/checklist/pull/12#issuecomment-361296395, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOI597jU6esUUBCDrp0Cyt_H9P1csjQks5tPe31gaJpZM4QXTsv .

davegurnell commented 6 years ago

I just published this as version 0.5.0. libraryDependencies settings are in the README on develop.

davegurnell / checklist

Update cats and monocle version #12

Codecov Report