Jacoby6000 commented 6 years ago

Additionally, made Eq and Order instances for Message and Path. Those will need law tests as well, but cats 0.9.0 doesn't have laws for those.

codecov[bot] commented 6 years ago

Codecov Report

Merging #13 into develop will increase coverage by 2.81%. The diff coverage is 80%.

@@             Coverage Diff             @@
##           develop      #13      +/-   ##
===========================================
+ Coverage    81.95%   84.76%   +2.81%     
===========================================
  Files           13       13              
  Lines          205      210       +5     
  Branches         2        3       +1     
===========================================
+ Hits           168      178      +10     
+ Misses          37       32       -5

Impacted Files	Coverage Δ
checklist/src/main/scala/checklist/Path.scala	`75% <100%> (+1.31%)`	:arrow_up:
checklist/src/main/scala/checklist/Rule.scala	`85.71% <100%> (+4.79%)`	:arrow_up:
checklist/src/main/scala/checklist/Message.scala	`83.33% <50%> (-16.67%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ff796f...a8afe1b. Read the comment docs.

Jacoby6000 commented 6 years ago

Codecov is mad because I added some typeclass instances, but have no tests for them. Their lawfulness is verified over in #12.

davegurnell commented 6 years ago

I'm not too fussed about Codecov. It's a useful tool for providing an overview of what's happening but it's not the end of the world if the coverage goes down IMO.

davegurnell commented 6 years ago

I'm trying to put out a snapshot release but I'm getting GPG errors. Sigh. I'll have to debug them later.

On Tue, Dec 19, 2017 at 4:29 PM Jacob Barber notifications@github.com wrote:

@Jacoby6000 https://github.com/jacoby6000 requested your review on: davegurnell/checklist#13 https://github.com/davegurnell/checklist/pull/13 Add law tests and profunctor instance for Rule..

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/davegurnell/checklist/pull/13#event-1394489894, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOI51745G2kW1ZGFTBS18GJta9XwLxdks5tB-RjgaJpZM4RFfHg .

davegurnell / checklist

Add law tests and profunctor instance for Rule. #13

Codecov Report