davegurnell / checklist

Validation library for Scala.
Apache License 2.0
47 stars 11 forks source link

add build.properties file #4

Closed aoiroaoino closed 6 years ago

aoiroaoino commented 7 years ago

I think that it is better to lock the version of sbt.

codecov[bot] commented 7 years ago

Codecov Report

Merging #4 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop       #4   +/-   ##
========================================
  Coverage    79.33%   79.33%           
========================================
  Files            6        6           
  Lines          121      121           
  Branches         1        1           
========================================
  Hits            96       96           
  Misses          25       25

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3442df...5cc655f. Read the comment docs.

dispalt commented 7 years ago

this isn't necessary anymore @aoiroaoino

davegurnell commented 7 years ago

Is it not? I'm happy to merge this, by the way, I've just been crap at responding to PRs on this library (sorry).

dispalt commented 7 years ago

Oh I just saw you had a https://github.com/davegurnell/checklist/blob/develop/project/build.properties

davegurnell commented 7 years ago

Aaaaah I see. Ok I'll close this when I'm next by a computer. Thanks for the PR and sorry for the confusion! On Thu, 31 Aug 2017 at 18:12, Dan Di Spaltro notifications@github.com wrote:

Oh I just saw you had a https://github.com/davegurnell/checklist/blob/develop/project/build.properties

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/davegurnell/checklist/pull/4#issuecomment-326362197, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOI52IpWzDwexH-BEmXOGW-IuuyKVRAks5sdumCgaJpZM4NBP5Y .

aoiroaoino commented 6 years ago

I see. no problem :)