search

davehornik / sd-discord-rich_presence

Discord Rich Presence for AUTOMATIC1111's Stable Diffusion WebUI
GNU Affero General Public License v3.0
21 stars 3 forks source link

any differences from other implementation? #4

Closed pixelqiwi closed 1 year ago

pixelqiwi commented 1 year ago

is this extension any different from this one? like it seems to do the same thing, except yours has like thrice the amount of code

Edesak commented 1 year ago

The difference is we provide number of images you generating, He is only providing sampling steps. That means when you generating for example 10 batch count with 3 batch size it will restart you sampling steps. We provide the information of number of images, in this example i provided it is 30 images you trying to make.

If i go to more detail in his code for the number of images 

Generating {shared.state.job_count} Picture(s)

This shared.state.job_count will not return true number of images you generating. It only returns the batch count. But the true number of images is batch count * batch size.

Plus he is not considering the time you spending for generating. In ours it shows how much you are in Idle mode and how much time you are in generating mode and we provide cleaner name of the model not (*.safetensor) but only the name.

Bit of sneak peak but we considering to add some kind of status in what stage of the generating you are but we will see :).

But the repository you provided should be functional. If you don`t care about these extra information.

Short answer: Yes there is difference.

Any more questions or i can close your issue ?

Edesak commented 1 year ago

this issue is here more then 2 days i'm closing it then