search

davej / angular-classy

Cleaner class-based controllers with Angular 1
http://davej.github.io/angular-classy/
813 stars 27 forks source link

Add npm support #50

Closed mattlewis92 closed 8 years ago

davej commented 8 years ago

Awesome! Does usage work like this?

const angular = require('angular');
const classy = require('angular-classy')

const app = angular.module('app', [classy]);
mattlewis92 commented 8 years ago

Yup 😄

mattlewis92 commented 8 years ago

Awesome, thanks for the quick response! You'll just need to checkout the repo now and run npm publish to get it on npm 😄

davej commented 8 years ago

Cool, published as v1.2.4.

mattlewis92 commented 8 years ago

Thanks! :octocat:

davej commented 8 years ago

Should angular also be moved out of dependencies and into peerDependencies and devDependencies instead?

mattlewis92 commented 8 years ago

It doesn't look like it's in the dependencies list currently, you'd only need to add it to dev dependencies if you're using commonjs in your build process. Adding it to peer dependencies wouldn't add much really as for 99% of apps angular will already be installed.

davej commented 8 years ago

Ah, you're right, I was looking at the bower.json at the time.

Thanks!