Closed mjforan closed 2 years ago
Hi @mjforan, thank you for this contribution! These are some great changes. I wonder if adding a version number to the package.json
file will help fix the version mismatch error you were seeing and allow us to keep the package-lock.json
file. It's best practice to keep the package-lock.json
file checked in to version control. Other than that, this looks great.
I wonder if adding a version number to the
package.json
file will help fix the version mismatch error you were seeing and allow us to keep thepackage-lock.json
file. It's best practice to keep thepackage-lock.json
file checked in to version control.
Oops I wasn't aware; I added the file back. The issue I saw wasn't major and users can always delete the file on their own, so I wouldn't worry about that.
shell=True
to subprocess run command to make it work on Linuxfor i in range(submission.attempt)