davekats / canvas-student-data-export

Python script to download all of your student data from Canvas LMS
123 stars 33 forks source link

Bug fixes, better linux compatibility #9

Closed mjforan closed 2 years ago

mjforan commented 2 years ago
davekats commented 2 years ago

Hi @mjforan, thank you for this contribution! These are some great changes. I wonder if adding a version number to the package.json file will help fix the version mismatch error you were seeing and allow us to keep the package-lock.json file. It's best practice to keep the package-lock.json file checked in to version control. Other than that, this looks great.

mjforan commented 2 years ago

I wonder if adding a version number to the package.json file will help fix the version mismatch error you were seeing and allow us to keep the package-lock.json file. It's best practice to keep the package-lock.json file checked in to version control.

Oops I wasn't aware; I added the file back. The issue I saw wasn't major and users can always delete the file on their own, so I wouldn't worry about that.