search

davekeck / Xcode-4-Fixins

Plugins for fixing Xcode 4 bugs and shortcomings
362 stars 41 forks source link

Switch to MRR (from GC) in CurrentLineHighlighter for Xcode5 #28

Open andyarvanitis opened 11 years ago

PaulCapestany commented 11 years ago

@andyarvanitis thanks so much for this fix — works great!

andyarvanitis commented 11 years ago

You're welcome! I intended to pull it into the main repo a few days ago (I actually have the rights to), but wanted Dave (or anyone else) to have a look first.

PaulCapestany commented 11 years ago

The only issue I noticed was with the "XCode5 Comptability" build script. _XCFixinCurrentLineHighlighter was one of the plugins hard-coded to be disabled within that in the Build All Fixins target.

tspinelli commented 10 years ago

I tried to use this commit within Xcode 5.0.2 and do not see the new entry under the edit menu and the current line is not highlighting.

I pulled this commit, built the project and then re-ran Xcode. Additionally, the plugin is in my plugins directory. Am I missing something?

This was previously one of my favorite plugins for xcode! I would love to see it working again!

PaulCapestany commented 10 years ago

@tspinelli it's still working for me fine with the latest version of Xcode. Did you look under the Editor menu (instead of Edit)?

RobertAudi commented 10 years ago

Same problem as @tspinelli here. Not working :disappointed:

tom-seddon commented 10 years ago

I'm fixing up the fixins for Xcode 5.1. It complained about GC, so I just let it convert everything to ARC, and CurrentLineHighlighter seems to be working fine for me.

Andy, do you think this will be OK, or should I take your manual retain/release code instead?

Removing GC does cause problems with Xcode 4.6.2 though...

--Tom

andyarvanitis commented 10 years ago

I think using your ARC conversion is definitely fine -- thanks!

tom-seddon commented 10 years ago

Preliminary Xcode 5.1 support can be found in the xcode_51_arc branch. This includes a version of CurrentLineHighlighter that at least seems to work for me with Xcode 5.1. So there are now no disabled fixins in that branch.

This stuff is in its own branch for now as it's a bit WIP, and as it builds with ARC it's completely incompatible with Xcode 4.6.2 (and I've no idea if it works on Xcode 5.0.x.) I've opened issue #31 regarding continued Xcode 4 support, if anybody wants to comment.

Thanks,

--Tom

tspinelli commented 10 years ago

This still doesn't work for me. I did have it working previously under XCode 4, but ever since moving to XCode 5 I have never had it working. I just tried the 5.1 branch to check it out, but it doesn't work either. I've tried deleting the plugin, restarting Xcode, reinstalling and it still doesn't work.

Any thoughts?

andyarvanitis commented 10 years ago

It looks like it's just missing the compatibility UUID. I'll look into adding it today and pushing it up to the 5.1_arc branch.

tom-seddon commented 10 years ago

Did you get any further with this? I didn't have any problems with Xcode 5.1 myself and it looked like the compatibility UUID should already be applied to all fixins.

--Tom

andyarvanitis commented 10 years ago

No, sorry, I didn't. I'm sure I got sidetracked by some day-job thing. I've definitely been using the highlighter with 5.1 (local change) for a long time now, and everything seems to work fine.

tom-seddon commented 10 years ago

Oh - no apology necessary! I was planning on rearranging the branches (see #31) and was just wondering whether to hold off.

--Tom