search

davemacdo / composer-diversity

a frontend for the Composer Diversity Project
https://davemacdo.github.io/composer-diversity/
9 stars 2 forks source link

Badges on composer cards #2

Closed robdeemer closed 6 years ago

robdeemer commented 6 years ago

I'm thinking that we can forgo the sun/moon emoji (which are small) because those that are dead will have a death date after their name, so the emoji are redundant. Thanks!

davemacdo commented 6 years ago

Agreed. They didn't match well with the other badges, either. I've just removed them.

robdeemer commented 6 years ago

I just got done speaking with Alex Shapiro and we came to the conclusion that it'd be fine if all of the badges go away! It'll help with de-cluttering the page, it may help with spacing, and if someone is looking for a different or specific filter, all they have to do is click the button. Thoughts?

davemacdo commented 6 years ago

I kind of like having the extra information. I kind of like seeing what else might be available from the same composer. What about just keeping the genre badges and removing the gender and demographic badges?

robdeemer commented 6 years ago

Let's try it and see how it works đź‘Ť

davemacdo commented 6 years ago

Now it's only showing genre/medium badges, and they're all the same color. Thoughts?

robdeemer commented 6 years ago

Let's put back the gender badges so folks don't have to guess (some names are tricky that way).

davemacdo commented 6 years ago

Good point. I've added them back. I'm open to other ways of showing the same information.

Maybe with a little more time, there could be an icon system? Right now, you can see the meaning of a badge by hovering over it, but there might be something that is a little more explanatory in an icon.

robdeemer commented 6 years ago

This actually answers another question I just sent about a key. Rollover is great…but we should provide instructions on the page that that's in effect (otherwise folks might not realize it's there)

davemacdo commented 6 years ago

I'm going to mark this as closed and deal with the badge "legend" in this issue.