Closed robdeemer closed 6 years ago
davemacdo
commented
6 years ago I would rather have it included in the results for the existing search box, rather than adding any other inputs to the screen. Let me see what I can do. Some of the work I did refactoring last week should make this very doable.
davemacdo
commented
6 years ago Ok. So that was a lot easier than I thought. A good test is searching for [Port], which will return composers whose name includes the string "port", as well as composers from both Portland and Portugal, which also strikes me as a good, completely nonsensical theme for a concert program.
robdeemer
commented
6 years ago Works really well! Do you think I should spell out the states rather than having the abbreviations?
On Mon, May 21, 2018 at 11:38 AM, David MacDonald notifications@github.com wrote:
Closed #29 https://github.com/davemacdo/composer-diversity/issues/29.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davemacdo/composer-diversity/issues/29#event-1637318130, or mute the thread https://github.com/notifications/unsubscribe-auth/AlCxlZ3zhX5hhbF5YmljR9SXC2CQeC85ks5t0t-NgaJpZM4UHHu2 .
--
Dr. Rob Deemer Head of Music Composition & Special Assistant to the President American Council on Education Fellow (2016-2017) School of Music, State University of New York at Fredonia
Chair, NYSSMA Composition & Improvisation Committee Chair-Elect, NAfME Council of Music Composition
Composer-in-Residence, Buffalo Chamber Players http://buffalochamberplayers.org/ Composer-in-Residence, Harmonia Chamber Singers https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=0CB4QFjAAahUKEwjmv7jhh-3IAhWLdD4KHSr2CNM&url=http%3A%2F%2Fwww.harmoniacs.org%2F&usg=AFQjCNGgWsCqj4leupJVTtIhJNwYXY26nw&sig2=TKTS2XdNhV0m9B3O3b0-jg
3162 Mason Hall • Fredonia, NY 14063 • (716) 673-3133 e-mail: deemer@fredonia.edu • web: www.robdeemer.com
davemacdo
commented
6 years ago It could go either way. Having the full name is easier to search but makes for more clutter on the page. If we had both in the data, I could have the app search using the full name but only display the abbreviation.
robdeemer
commented
6 years ago Where should I put the 2nd iteration? A different column?
On Tue, May 22, 2018 at 8:42 AM, David MacDonald notifications@github.com wrote:
Reopened #29 https://github.com/davemacdo/composer-diversity/issues/29.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davemacdo/composer-diversity/issues/29#event-1639202431, or mute the thread https://github.com/notifications/unsubscribe-auth/AlCxlVvBa1yqzYm53DP0Q6uRsxqJ6ANuks5t1AergaJpZM4UHHu2 .
--
Dr. Rob Deemer Head of Music Composition & Special Assistant to the President American Council on Education Fellow (2016-2017) School of Music, State University of New York at Fredonia
Chair, NYSSMA Composition & Improvisation Committee Chair-Elect, NAfME Council of Music Composition
Composer-in-Residence, Buffalo Chamber Players http://buffalochamberplayers.org/ Composer-in-Residence, Harmonia Chamber Singers https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=0CB4QFjAAahUKEwjmv7jhh-3IAhWLdD4KHSr2CNM&url=http%3A%2F%2Fwww.harmoniacs.org%2F&usg=AFQjCNGgWsCqj4leupJVTtIhJNwYXY26nw&sig2=TKTS2XdNhV0m9B3O3b0-jg
3162 Mason Hall • Fredonia, NY 14063 • (716) 673-3133 e-mail: deemer@fredonia.edu • web: www.robdeemer.com
davemacdo
commented
6 years ago It could be a separate column, or it could be inside the current column as something like "New York (NY)".
robdeemer
commented
6 years ago Done—a separate column with everything spelled out (and a number of errors checked!). Thanks!
On Tue, May 22, 2018 at 9:03 AM, David MacDonald notifications@github.com wrote:
It could be a separate column, or it could be inside the current column as something like "New York (NY)".
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davemacdo/composer-diversity/issues/29#issuecomment-390981486, or mute the thread https://github.com/notifications/unsubscribe-auth/AlCxlZHTY_srPviiaTdvwrAVq3pCew_Kks5t1AyegaJpZM4UHHu2 .
--
Dr. Rob Deemer Head of Music Composition & Special Assistant to the President American Council on Education Fellow (2016-2017) School of Music, State University of New York at Fredonia
Chair, NYSSMA Composition & Improvisation Committee Chair-Elect, NAfME Council of Music Composition
Composer-in-Residence, Buffalo Chamber Players http://buffalochamberplayers.org/ Composer-in-Residence, Harmonia Chamber Singers https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=0CB4QFjAAahUKEwjmv7jhh-3IAhWLdD4KHSr2CNM&url=http%3A%2F%2Fwww.harmoniacs.org%2F&usg=AFQjCNGgWsCqj4leupJVTtIhJNwYXY26nw&sig2=TKTS2XdNhV0m9B3O3b0-jg
3162 Mason Hall • Fredonia, NY 14063 • (716) 673-3133 e-mail: deemer@fredonia.edu • web: www.robdeemer.com
davemacdo
commented
6 years ago The version that is live now displays what is in the abbreviated city/state field, but searches by what is in the full city/state field. You can test by searching a full state name, like "California". In testing, I did find that there were a couple of records that had the full state in both columns. Not a big deal, but I thought you'd want to know. I'll close this issue for now.
robdeemer
commented
6 years ago It's not working yet…
On Tue, May 22, 2018 at 8:14 PM, David MacDonald notifications@github.com wrote:
The version that is live now displays what is in the abbreviated city/state field, but searches by what is in the full city/state field. You can test by searching a full state name, like "California". In testing, I did find that there were a couple of records that had the full state in both columns. Not a big deal, but I thought you'd want to know. I'll close this issue for now.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davemacdo/composer-diversity/issues/29#issuecomment-391180614, or mute the thread https://github.com/notifications/unsubscribe-auth/AlCxlfZw54b028msfZbpPeFU4pwWJdS6ks5t1KnlgaJpZM4UHHu2 .
--
Dr. Rob Deemer Head of Music Composition & Special Assistant to the President American Council on Education Fellow (2016-2017) School of Music, State University of New York at Fredonia
Chair, NYSSMA Composition & Improvisation Committee Chair-Elect, NAfME Council of Music Composition
Composer-in-Residence, Buffalo Chamber Players http://buffalochamberplayers.org/ Composer-in-Residence, Harmonia Chamber Singers https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=0CB4QFjAAahUKEwjmv7jhh-3IAhWLdD4KHSr2CNM&url=http%3A%2F%2Fwww.harmoniacs.org%2F&usg=AFQjCNGgWsCqj4leupJVTtIhJNwYXY26nw&sig2=TKTS2XdNhV0m9B3O3b0-jg
3162 Mason Hall • Fredonia, NY 14063 • (716) 673-3133 e-mail: deemer@fredonia.edu • web: www.robdeemer.com
davemacdo
commented
6 years ago Try doing a "hard refresh" (cmd-shift-R on Mac). Your browser may be using a cached copy of the app.
davemacdo
commented
6 years ago Ok. Actually it was my fault! I forgot to push a button. Button pushed. All good.
robdeemer
commented
6 years ago Sweet - thanks!
On Tue, May 22, 2018 at 8:43 PM, David MacDonald notifications@github.com wrote:
Ok. Actually it was my fault! I forgot to push a button. Button pushed. All good.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/davemacdo/composer-diversity/issues/29#issuecomment-391184905, or mute the thread https://github.com/notifications/unsubscribe-auth/AlCxlewC48QneCllJEhkuQJqFfZS6KXqks5t1LC7gaJpZM4UHHu2 .
--
Dr. Rob Deemer Head of Music Composition & Special Assistant to the President American Council on Education Fellow (2016-2017) School of Music, State University of New York at Fredonia
Chair, NYSSMA Composition & Improvisation Committee Chair-Elect, NAfME Council of Music Composition
Composer-in-Residence, Buffalo Chamber Players http://buffalochamberplayers.org/ Composer-in-Residence, Harmonia Chamber Singers https://www.google.com/url?sa=t&rct=j&q=&esrc=s&source=web&cd=1&ved=0CB4QFjAAahUKEwjmv7jhh-3IAhWLdD4KHSr2CNM&url=http%3A%2F%2Fwww.harmoniacs.org%2F&usg=AFQjCNGgWsCqj4leupJVTtIhJNwYXY26nw&sig2=TKTS2XdNhV0m9B3O3b0-jg
3162 Mason Hall • Fredonia, NY 14063 • (716) 673-3133 e-mail: deemer@fredonia.edu • web: www.robdeemer.com
Hi David, Any chance we can either include locations within the search box or create a 2nd search box so folks can look for composers within a country or state or city? Thanks!