search

davemacdo / composer-diversity

a frontend for the Composer Diversity Project
https://davemacdo.github.io/composer-diversity/
9 stars 2 forks source link

added Vue I18n, and en translation of static strings. #34

Closed ianring closed 6 years ago

ianring commented 6 years ago

This worked for me locally, but YMMV. I noticed that my local version of node updated all the package version numbers, so I hope that doesn't break things. Cheers Ian

ianring commented 6 years ago

addresses https://github.com/davemacdo/composer-diversity/issues/30

davemacdo commented 6 years ago

This looks good. Thanks, Ian! I'll take a closer look this afternoon.

Also, wow am I bad at tabs. Sorry you had to deal with my inconsistency. I changed part-way through the project, and thought I got them all, but apparently I wasn't even close. Ugh. I've always been a hard-tab person, but all the JS references I read use soft, two-spaces, so I decided to go with the Romans. After I merge this, I'll go through and clean it up so future contributions are a little easier to manage.

davemacdo commented 6 years ago

I'm going through this now, and I think it might be easier for me to copy lines into a new feature branch rather than a merge (because of my sloppiness). I'll clean up the tabs so that doesn't happen next time, and I may make a few comments along the way. I'll comment and close here when all is said and done.

davemacdo commented 6 years ago

I've used your work and merged it from local. Let me know if I messed anything up.