search

davemacdo / composer-diversity

a frontend for the Composer Diversity Project
https://davemacdo.github.io/composer-diversity/
9 stars 2 forks source link

Filter based on in or outside USA #7

Closed robdeemer closed 6 years ago

robdeemer commented 6 years ago

Is there any relatively painless way to do a search by location? Either by country or by state? Could it be something that you type in and it brings up everyone in that place? I could type in Chicago and everyone there comes up? Or USA?

See what happens when I start going down the rabbit hole?

davemacdo commented 6 years ago

Right now, the search field is only tied to the name, but it could also be tied to location.

I was thinking about US/non-US filters, which would be a lot coarser, but maybe get you most of the way to where you'd want to go.

robdeemer commented 6 years ago

That's a start…can we get two checkboxes for now (USA/Non-USA)?

davemacdo commented 6 years ago

That's totally reasonable. Shouldn't be too difficult to implement. You did a great job keeping the data consistent on abbreviating USA. I'll consider that the scope of this issue and move it to the 1.0 milestone.

robdeemer commented 6 years ago

Let's try this language: "Based in USA" "Based outside of USA"

davemacdo commented 6 years ago

With (I think) a clever bit of code, the USA filter is now functional.