davemlz / eemont

A python package that extends Google Earth Engine.
https://eemont.readthedocs.io/
MIT License
407 stars 69 forks source link

[JOSS Review] Comments #28

Closed patrickcgray closed 3 years ago

patrickcgray commented 3 years ago

It is clear this is a substantial scholarly effort and represents an excellent contribution to the remote sensing/scientific computing community. I don't think the paper/repo needs any substantial changes. It installed easily in a fresh virtual envronment via pip and conda and documentation was relatively straightforward. All code examples worked for me, installation was as documented, and the QGIS functionality worked as documented. I think it will be easy for GEE practitioners to implement.

Comments:

kbarnhart commented 3 years ago

linking with joss review issue openjournals/joss-reviews/issues/3168

davemlz commented 3 years ago

Hi, @patrickcgray! Thank you very much for the comments! I'll start working on your suggestions and let you know as soon as they're ready! :)

davemlz commented 3 years ago

Hi, @patrickcgray!

I have updated the paper following your suggested template for the Statement of Need and added some links to the README (and also to the main page of the Docs), including a link to the tutorials! :)

Thank you for the comments and suggestions again, @patrickcgray!

patrickcgray commented 3 years ago

Hey @davemlz nice work, I think everything looks good on my end! Closing this issue.

davemlz commented 3 years ago

Thank you, @patrickcgray!