Configuration Check Negation

davenonymous / OCXNetDriver

OpenComputers + XNet = ❤️

https://minecraft.curseforge.com/projects/oc-xnet-driver

4 stars 5 forks source link

Configuration Check Negation #9

Closed Nerdpie closed 5 years ago

Nerdpie commented 5 years ago

https://github.com/thraaawn/OCXNetDriver/blob/179b1a3590d0a8f58ff524c0a972d6d7a35b7dce/src/main/java/org/dave/ocxnetdriver/driver/controller/EnvironmentXnetController.java#L57-L65

I'm currently working on adding similar behavior into Plethora based on your code, and I noticed that you have the same check in toRelative and toAbsolute. Just thought I'd mention it!

davenonymous commented 5 years ago

Will look at this at some point, not sure if the naming is wrong or the methods.

Nerdpie commented 5 years ago

Upon closer inspection, the configuration check makes sense.

The toRelative method is used to convert the BlockPos for output, so it can return the input if the player is supposed to see the absolute position.
The toAbsolute method is used to convert the input BlockPos, so it only needs to sum the vectors if input should be relative coordinates.

The naming may be a bit confusing, but it should function just fine. Sorry for the false alarm!