davepar / gcalendarsync

Apps Script for syncing a Google Spreadsheet with Google Calendar
MIT License
161 stars 46 forks source link

Update improvements #17

Closed martindafonte closed 7 years ago

martindafonte commented 7 years ago
heymeee commented 7 years ago

hello those moffifications look excatly what i need,, is it working ? so it doenst trig the error anymore ( you ve been creating deleting too many events,,, it still works if we have like 300 to 800 events with one guest each time ? thanks a lot for any help i m stuck with the sheet not ssynching anymore with the cal. i use it for work with my colleagues,,,

martindafonte commented 7 years ago

Hi, I've it working with 300 events with no problem. Try it and let me know if you get any errors. I'm working on an addon right now, if you are interested I can send you the link.

On Tue, May 30, 2017, 12:04 heymeee notifications@github.com wrote:

hello those moffifications look excatly what i need,, is it working ? so it doenst trig the error anymore ( you ve been creating deleting too many events,,, it still works if we have like 300 to 800 events with one guest each time ? thanks a lot for any help i m stuck with the sheet not ssynching anymore with the cal. i use it for work with my colleagues,,,

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Davepar/gcalendarsync/pull/17#issuecomment-304907531, or mute the thread https://github.com/notifications/unsubscribe-auth/AMvOgZZsKDiw_cW9yMfK85FZFFw6CEjaks5r_C_ngaJpZM4NTWoe .

-- Martín Da Fonte

heymeee commented 7 years ago

hello Martin i m sure very interested !! should i just copy all the code and paste it instead of the one from Dave Par ? sorry i not a genius,,, ;) the issue is about deleting and recreating events i guess,,,

heymeee commented 7 years ago

would you please paste the code here ? do i have to moddify the sheet ? can i use your code with the sheet i already have filled up with events ID from the cal ? thank you so much

heymeee commented 7 years ago

i pasted the code and get the error : ReferenceError: L'élément "config" n'est pas défini.DétailsIgnorer Détails du message ReferenceError: L'élément "config" n'est pas défini.

martindafonte commented 7 years ago

Hi @heymeee I've added a new commit fixing the errors you found. The problem was I ported back these changes from a refactor I was doing, I tested the changes and now they are working all right.

heymeee commented 7 years ago

ouaa thank you guys !!! i m kinda new to github,,, how can i getthe full working code ? i see you did a few changes,,,, thank you !!

martindafonte commented 7 years ago

Hi @Davepar I worked on your suggestions, also fixed a mistake on bracket that was causing some trouble. @heymeee you can get the full code with this fixes here: update_improvements

heymeee commented 7 years ago

hey Martin i cant thank you enough gonna try this asap today and let you guys know

heymeee commented 7 years ago

hey Martin i pasted the code instead of old one but still get the same error,, You have been creating or deleting too many calendars or calendar events in a short time. Please try again later i have 258 events already in the sheet and calendar with IDs and i m trying to add 35 evetns from the sheet with the new code,, i tried it with another cal and re added the 258 events at once without guests and it worked

weird

thank you

martindafonte commented 7 years ago

Thanks @Davepar for merging the PR

@heymeee I will look into that to see if there is anything amiss with the guests on an event.

heymeee commented 7 years ago

thank you so much Dave very grateful

heymeee commented 7 years ago

the script just allowed me toadd one event with one guest again but trigs error when trying to add like 10 events but also i played with it a few times, so add to cancel 200 events,, that s maybe why too,,

heymeee commented 7 years ago

sorry to bother you guys but last update if it can help,, this morning i could add 18 events with one guest each before triggering the error

martindafonte commented 7 years ago

I think there might be a problem with how is comparing for guests. On the weekend I'll look into it.

Regards

On Thu, Jun 1, 2017, 04:31 heymeee notifications@github.com wrote:

sorry to bother you guys but last update if it can help,, this morning i could add 18 events with one guest each before triggering the error

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Davepar/gcalendarsync/pull/17#issuecomment-305412949, or mute the thread https://github.com/notifications/unsubscribe-auth/AMvOgePIC_FBUHiYngx9ZGyw5By9fAPYks5r_mjjgaJpZM4NTWoe .

-- Martín Da Fonte

heymeee commented 7 years ago

thanks a lot !