Linking to specific moves in the history

dexonsmith commented 11 years ago

I've added linking from the chat to specific moves in the history.

There's a new handler, HistoryMoveHandler, that shares most of its code with HistoryHandler. It takes an extra 'move' argument in the URL: /history/([-\w]+)/(0|[1-9]\d*)/. The only difference is that the history is initialized to the specified move instead of the latest one. If the move doesn't exist, it just goes to the latest one.
/service/get-historical-state/ now reports the max move number. As a result, the history page will notice if a new move has been made, and update the (out of {{max}}) text.
The chat auto-linkifies any \B#(0|[1-9]\d*)\b to a link to that move in the history. For example, #5 will go to the fifth move. However, the #4 in abc#4 will not match, which should protect funny URLs that get pasted into the chat.
Each chat entry includes the move number before the name. This serves the practical purpose of anchoring the message to the move to which it refers. It's also pedagogical: users should pretty quickly discover how to make move links of their own.

dexonsmith commented 11 years ago

FYI, I added another couple of commits (d4ee090 and f4d46d5) which add a view of the chat to the history page, which I think will really help with game reviews (both writing them and reading them). Chat links to specific moves use javascript to talk directly to the history controller (rather than using the new service).

davepeck commented 11 years ago

Hi @duncanexonsmith -- I clearly need to pay more attention to my GitHub notifications. This looks really great and I will take a look at it (and hopefully merge it) this weekend!

Rock and roll and jazz!

davepeck commented 11 years ago

Wow. So cool. Thanks so much @duncanexonsmith

dexonsmith commented 11 years ago

Glad it works, @davepeck! Thanks for reviewing.

davepeck / game-of-go

Linking to specific moves in the history #15