search

daveray / dorothy

Hiccup-style generation of Graphviz graphs in Clojure
246 stars 25 forks source link

Support cmd/ctrl+w for closing the swing window #4

Closed brandonbloom closed 10 years ago

brandonbloom commented 10 years ago

It was driving me nuts that I couldn't close the swing window via keyboard.

This PR is to the master branch, since I'm using the latest version that was on Clojars: 0.4.0

daveray commented 10 years ago

Cool. I'm glad someone's using it :)

I'll merge and push a new release tonight.

brandonbloom commented 10 years ago

I've been hand-generating and spitting dot syntax from test apps for as long as I can remember, but when I got bit by an escaping bug, I decided to give Dorothy a try. Seems to work a treat! Thanks! I much prefer the embrace-data clojure-y approach you've got, rather than some of the other attempts I spotted that seem to have large APIs.

While I'm giving feedback, the one thing that surprised/confused me what that it seemed like I had to give the digraph function a vector. Ideally, I could give it a tree of lazy seqs that simply get flattened out during rendering.

daveray commented 10 years ago

Yeah. At the time I don't think I really "got" Hiccup and it took a while to get through my head that vectors represent elements and lists/seqs/etc all got flattened out. I'll try adding that. Should make programmatically generating graphs much more friendly.

daveray commented 10 years ago

Merged and released 0.0.5.

Also dropped git-flow. Slight overkill there.