search

daveshanley / vacuum

vacuum is the worlds fastest OpenAPI 3, OpenAPI 2 / Swagger linter and quality analysis tool. Built in go, it tears through API specs faster than you can think. vacuum is compatible with Spectral rulesets and generates compatible reports.
https://quobix.com/vacuum
MIT License
490 stars 39 forks source link

regression in `path-params` rule, complains about missing path params that are valid #390

Closed TristanSpeakEasy closed 4 months ago

TristanSpeakEasy commented 7 months ago

I am seeing these errors showing up in the latest vacuum release

"validation error: [line 35] path-params - `POST` must define parameter `org` as expected by path `/test2/org/{org}/team/{team}` | $.paths['/test2/org/{org}/team/{team}'].post",
"validation error: [line 35] path-params - `POST` must define parameter `team` as expected by path `/test2/org/{org}/team/{team}` | $.paths['/test2/org/{org}/team/{team}'].post",

that are new regressions, the attached specs show the issue and are definitely valid.

references.zip

TristanSpeakEasy commented 5 months ago

@daveshanley any luck figuring out this one?

daveshanley commented 4 months ago

This has been resolved in v0.9.0 It was fixed in libopenapi and a test was added to ensure it would not return.

https://github.com/pb33f/libopenapi/blob/main/index/spec_index_test.go#L1618